Skip to content

fix: move product.overrides resolution to an earlier stage#263743

Merged
deepak1556 merged 2 commits intomainfrom
robo/fix_product_overrides_resolution_v2
Aug 28, 2025
Merged

fix: move product.overrides resolution to an earlier stage#263743
deepak1556 merged 2 commits intomainfrom
robo/fix_product_overrides_resolution_v2

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

product values used within main.ts before startup, ex: product.dataFolderName in

let dataFolderName = product.dataFolderName;
don't get the values from override since resolution of the file happens in bootstrap-esm. This came up as a bug, when we tried to read an incorrect argv file in
const argvContent = await this.fileService.readFile(this.environmentMainService.argvResource);

@deepak1556 deepak1556 added this to the August 2025 milestone Aug 28, 2025
@deepak1556 deepak1556 self-assigned this Aug 28, 2025
@deepak1556 deepak1556 requested a review from bpasero as a code owner August 28, 2025 04:54
@deepak1556 deepak1556 enabled auto-merge (squash) August 28, 2025 04:55
bpasero
bpasero previously approved these changes Aug 28, 2025
@deepak1556 deepak1556 force-pushed the robo/fix_product_overrides_resolution_v2 branch from f6b41e7 to 4b72c9c Compare August 28, 2025 07:29
@deepak1556 deepak1556 requested a review from bpasero August 28, 2025 08:37
@deepak1556 deepak1556 merged commit 7120c40 into main Aug 28, 2025
18 checks passed
@deepak1556 deepak1556 deleted the robo/fix_product_overrides_resolution_v2 branch August 28, 2025 09:56
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants