fix: move product.overrides resolution to an earlier stage#263743
Merged
deepak1556 merged 2 commits intomainfrom Aug 28, 2025
Merged
fix: move product.overrides resolution to an earlier stage#263743deepak1556 merged 2 commits intomainfrom
deepak1556 merged 2 commits intomainfrom
Conversation
bpasero
previously approved these changes
Aug 28, 2025
f6b41e7 to
4b72c9c
Compare
DonJayamanne
approved these changes
Aug 28, 2025
bpasero
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
product values used within
main.tsbefore startup, ex:product.dataFolderNameinvscode/src/main.ts
Line 436 in 7a1d7c4
bootstrap-esm. This came up as a bug, when we tried to read an incorrect argv file invscode/src/vs/code/electron-main/app.ts
Line 1427 in 7a1d7c4