Fix inconsistency between JSON schema and code for secondary sidebar view containers#264864
Merged
Fix inconsistency between JSON schema and code for secondary sidebar view containers#264864
Conversation
…view containers Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] The key must be secondarySideBar for it to work (which causes a JSON schema error)
Fix inconsistency between JSON schema and code for secondary sidebar view containers
Sep 3, 2025
benibenj
approved these changes
Sep 3, 2025
DonJayamanne
approved these changes
Sep 3, 2025
lszomoru
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension developers were required to use
"secondarySideBar"(uppercase B) in theirpackage.jsonto register view containers in the secondary sidebar, but this caused JSON schema validation errors because the schema expected"secondarySidebar"(lowercase b).The issue was caused by an inconsistency between:
'secondarySidebar'(lowercase b)'secondarySideBar'(uppercase B)'contribSecondarySideBar'(uppercase B)This fix makes everything consistent by using
secondarySidebar(lowercase b) throughout:'secondarySideBar'to'secondarySidebar'inviewsExtensionPoint.ts'contribSecondarySideBar'to'contribSecondarySidebar'inextensionsApiProposals.tscontribSecondarySideBar.d.tstocontribSecondarySidebar.d.tsand updated the URL referenceNow extension developers can use the correct schema-compliant syntax without validation errors:
{ "contributes": { "viewsContainers": { "secondarySidebar": [ { "id": "myViewContainer", "title": "My View Container", "icon": "$(symbol-class)" } ] } }, "enabledApiProposals": ["contribSecondarySidebar"] }Fixes #264529.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.orgnode-gyp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.