Finalize Auth Challenges caller API#268006
Merged
TylerLeonhardt merged 1 commit intomainfrom Sep 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes the Auth Challenges caller API by removing deprecated legacy support code and API gates. The changes clean up backward compatibility code that was intended to be temporary, indicating the new authentication challenge API is now stable.
Key changes:
- Remove deprecated legacy shape handling for authentication requests
- Remove API gate check for authentication challenges feature
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/api/common/extHostAuthentication.ts | Removes deprecated backward compatibility code for old authentication request format |
| src/vs/workbench/api/common/extHost.api.impl.ts | Removes proposed API gate check for authentication challenges |
mjbvz
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #260156