mark chatModes contribution point as proposed#268866
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR marks chat-related extension contribution points (chatPromptFiles, chatInstructions, and chatModes) as proposed APIs by adding the required API enablement check.
- Adds proposed API validation for chat prompt file contributions
| private handle(extensionPoint: extensionsRegistry.IExtensionPoint<IRawChatFileContribution[]>, contributionPoint: ChatContributionPoint) { | ||
| extensionPoint.setHandler((_extensions, delta) => { | ||
| for (const ext of delta.added) { | ||
| checkProposedApiEnabled(ext.description, 'chatParticipantPrivate'); |
There was a problem hiding this comment.
The API identifier 'chatParticipantPrivate' appears incorrect for chat prompt files contributions. Based on the context that this handles 'chatPromptFiles', 'chatInstructions', and 'chatModes' contribution points, the API identifier should likely be something like 'chatPromptFiles' or a more generic chat-related identifier rather than 'chatParticipantPrivate'.
Suggested change
| checkProposedApiEnabled(ext.description, 'chatParticipantPrivate'); | |
| checkProposedApiEnabled(ext.description, contributionPoint); |
aeschli
changed the title
bpasero
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #251580