Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the latest MCP (Model Context Protocol) specification version 2025-16-09 to the VS Code MCP gallery service. The changes include defining new schema types and updating the serializer registration to handle the newest spec version.
Key Changes
- Add new namespace
McpServerSchemaVersion_2025_16_09with updated type definitions - Register the new serializer for version 2025-16-09 in the gallery service
- Minor reordering of the
statusfield in the existingIRawGalleryMcpServerinterface
Comment on lines
+938
to
+940
| namespace McpServerSchemaVersion_2025_16_09 { | ||
|
|
||
| export const VERSION = '2025-16-09'; |
There was a problem hiding this comment.
The date format '2025-16-09' is invalid as there is no 16th month. This should likely be '2025-09-16' (September 16th) or follow the intended date format for the MCP specification.
Suggested change
| namespace McpServerSchemaVersion_2025_16_09 { | |
| export const VERSION = '2025-16-09'; | |
| namespace McpServerSchemaVersion_2025_09_16 { | |
| export const VERSION = '2025-09-16'; |
Comment on lines
+938
to
+940
| namespace McpServerSchemaVersion_2025_16_09 { | ||
|
|
||
| export const VERSION = '2025-16-09'; |
There was a problem hiding this comment.
This schema URL will be invalid due to the malformed date in VERSION. The URL will contain '2025-16-09' which doesn't represent a valid date, potentially causing the schema reference to fail.
Suggested change
| namespace McpServerSchemaVersion_2025_16_09 { | |
| export const VERSION = '2025-16-09'; | |
| namespace McpServerSchemaVersion_2025_09_16 { | |
| export const VERSION = '2025-09-16'; |
dmitrivMS
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.