remove elicitation prompt on timeout or when user interacts with it#268905
Merged
meganrogge merged 4 commits intomainfrom Sep 29, 2025
Merged
remove elicitation prompt on timeout or when user interacts with it#268905meganrogge merged 4 commits intomainfrom
meganrogge merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression where terminal command completion handling was incorrectly disposing of prompt parts instead of just hiding them. The changes standardize the cleanup behavior to only hide elicitation prompts when commands finish, avoiding premature disposal.
Key changes:
- Remove explicit
dispose()calls on prompt parts throughout the output monitor - Make
hide()calls async where appropriate and add proper await handling - Refactor
ChatElicitationRequestPartto use observable for hidden state instead of disposal tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
outputMonitor.ts |
Remove dispose calls on prompt parts and make hide operations async |
chatService.ts |
Remove return type from hide method signature |
chatElicitationRequestPart.ts |
Replace disposal-based hiding with observable state management |
auto-merge was automatically disabled
September 29, 2025 16:53
Pull request was converted to draft
meganrogge
changed the title
dmitrivMS
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #268836
This regressed with a recent change I made. Also, noticed the disposes were not happening as expected.
demo-fix.mov
Before:
After:
The response always indicates what happened, so I don't think we should keep that prompt in the list.