Skip to content

prevent multiple hides#268940

Merged
meganrogge merged 1 commit intomainfrom
merogge/hidden
Sep 29, 2025
Merged

prevent multiple hides#268940
meganrogge merged 1 commit intomainfrom
merogge/hidden

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings September 29, 2025 19:38
@meganrogge meganrogge self-assigned this Sep 29, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a guard to prevent multiple hide operations on the ChatElicitationRequestPart component. The change ensures that the hide method returns early if the component is already hidden, preventing redundant state changes and potential duplicate disposal calls.

  • Adds early return guard in hide() method to check if already hidden
  • Prevents redundant state updates and disposal calls

@meganrogge meganrogge added this to the September 2025 milestone Sep 29, 2025
@meganrogge meganrogge enabled auto-merge (squash) September 29, 2025 19:38
@meganrogge meganrogge merged commit 16e848c into main Sep 29, 2025
28 checks passed
@meganrogge meganrogge deleted the merogge/hidden branch September 29, 2025 19:50
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants