use modal to align with other voice action#269598
Merged
meganrogge merged 4 commits intomainfrom Oct 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the terminal voice action to use a modal dialog instead of a notification when prompting users to install or enable the Speech extension. This change aligns the terminal voice behavior with other voice actions in VS Code.
- Replaces notification-based prompts with modal dialogs for better user experience
- Simplifies the action handling by using dialog confirmation instead of multiple notification actions
- Updates messaging to be more user-friendly with question-based prompts
…lVoiceActions.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joshspicer
previously approved these changes
Oct 2, 2025
dmitrivMS
previously approved these changes
Oct 2, 2025
dmitrivMS
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #269588