Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves disposable resource management by ensuring proper cleanup in case of exceptions during language model provider registration. The fix addresses a potential resource leak where disposables could be left undisposed if an error occurs during the registration process.
Key changes:
- Replaces automatic disposal management with explicit try-catch error handling
- Ensures disposables are properly cleaned up when registration fails
Comment on lines
+58
to
+59
| const disposables = new DisposableStore(); | ||
| try { |
There was a problem hiding this comment.
The disposables are no longer being added to this._store, which means they won't be automatically disposed when the MainThreadLanguageModels instance is disposed. Consider adding disposables to this._store after successful registration to ensure proper cleanup during instance disposal.
dmitrivMS
approved these changes
Oct 2, 2025
roblourens
approved these changes
Oct 2, 2025
rzhao271
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better fix of #269498
Fixes #269498