Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements layer validation in CSS files to enforce architectural boundaries within VS Code's codebase. The change prevents base, platform, and editor layer CSS files from using .monaco-workbench classes, which violates the layered architecture.
- Adds layer-checker rule to stylelint that detects
.monaco-workbenchusage in restricted paths - Implements disable mechanism for files that need to bypass the rule
- Removes unused linting parameter from hygiene function
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| build/stylelint.js | Implements layer-checker rule with pattern matching and disable functionality |
| src/vs/editor/contrib/symbolIcons/browser/symbolIcons.css | Adds layer-checker disable comment |
| src/vs/editor/browser/services/hoverService/hover.css | Adds layer-checker disable comment |
| build/lib/stylelint/vscode-known-variables.json | Adds new chat and inline chat CSS variables |
| build/hygiene.js | Removes unused linting parameter and simplifies function signature |
| build/gulpfile.hygiene.js | Updates hygiene function call to remove unused parameter |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lszomoru
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.