Skip to content

Fix blue NES arrow display issue for code block highlighting#269682

Merged
benibenj merged 1 commit intomainfrom
benibenj/chosen-bug
Oct 3, 2025
Merged

Fix blue NES arrow display issue for code block highlighting#269682
benibenj merged 1 commit intomainfrom
benibenj/chosen-bug

Conversation

@benibenj
Copy link
Copy Markdown
Contributor

@benibenj benibenj commented Oct 3, 2025

Copilot Generated Description: Adjust the logic in the InlineCompletionsModel to correctly handle the display of the blue NES arrow when a code block is highlighted. This change ensures that the arrow only appears when appropriate conditions are met.

Fixes microsoft/vscode-copilot-issues#297

Copilot AI review requested due to automatic review settings October 3, 2025 09:48
@benibenj benibenj enabled auto-merge October 3, 2025 09:48
@benibenj benibenj self-assigned this Oct 3, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the blue NES arrow display for code block highlighting in the inline completions model. The change adjusts the order of condition checks to ensure the arrow appears only when appropriate.

Key Changes

  • Reordered the _tabShouldIndent condition check to appear earlier in the logic flow
  • Moved the tab indentation check before other conditions to prevent incorrect arrow display

@vs-code-engineering vs-code-engineering Bot added this to the October 2025 milestone Oct 3, 2025
@benibenj benibenj merged commit 3282e87 into main Oct 3, 2025
28 checks passed
@benibenj benibenj deleted the benibenj/chosen-bug branch October 3, 2025 10:50
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants