Revert "Generate policy data as JSON"#272362
Merged
Merged
Conversation
This reverts commit 99c299e.
joshspicer
approved these changes
Oct 20, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previous changes that introduced JSON-based policy data generation. The revert removes the policy export infrastructure and returns to the previous approach where policy data is parsed directly from TypeScript source files at build time using tree-sitter instead of being pre-generated as JSON.
Key changes:
- Removed policy export contribution and related infrastructure
- Removed JSON policy data file and DTO definitions
- Reverted policy configuration properties to use simple
descriptionfield instead of structuredlocalizationobject - Removed
categoryfield from policy definitions - Updated build scripts to parse policies directly from source rather than from JSON
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/workbench.desktop.main.ts | Removed import of policy export contribution |
| src/vs/workbench/contrib/policyExport/* | Deleted policy export contribution and integration test files |
| src/vs/platform/environment/* | Removed exportPolicyData property and command-line argument |
| src/vs/base/common/policy.ts | Removed PolicyCategory, LocalizedValue, and structured localization from IPolicy interface |
| build/lib/policies.ts | Reverted to parse policies directly from TypeScript files using tree-sitter instead of from JSON |
| build/lib/policies/policyData.jsonc | Deleted generated JSON policy data file |
| build/lib/policies/copyPolicyDto.* | Deleted policy DTO copying scripts |
| build/package.json | Removed pre-build script that copied policy DTOs |
| src/vs/workbench/contrib//browser/.contribution.ts | Reverted policy definitions to use simple description instead of localization object |
| src/vs/workbench/services//test/ | Updated test fixtures to remove category and localization properties |
| build/azure-pipelines//steps/.yml | Updated build commands to not pass JSON file argument |
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #272018