chat todos - drop offscreen status element#273578
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the offscreen status element from the chat todo list widget, simplifying the accessibility implementation. Previously, the widget used a visually hidden status text element with aria-describedby to convey status information to screen readers. This change eliminates that redundant element since the status information is already included in the aria-label attribute.
Key Changes
- Removed the offscreen
.todo-status-textelement and its associated positioning styles - Removed the
aria-describedbyattribute that referenced the now-deleted status element - Updated tests to reflect the new accessibility implementation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chatContentParts/chatTodoListWidget.ts | Removed statusElement from template interface and renderer, eliminated offscreen status text creation and positioning code, removed aria-describedby attribute |
| src/vs/workbench/contrib/chat/test/browser/chatTodoListWidget.test.ts | Updated test from checking hidden status elements to verifying aria-describedby attributes on todo items |
Collaborator
|
@bhavyaus can you pls ensure this still works without that? |
Member
Author
|
@meganrogge so I did on macOS screen reader and saw the status text! |
meganrogge
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offscreen element should not be needed given we set the
aria-labelwith the status text.