Skip to content

Finalize secondary sidebar view contribution point#273594

Merged
benibenj merged 1 commit intomainfrom
benibenj/disastrous-termite
Oct 27, 2025
Merged

Finalize secondary sidebar view contribution point#273594
benibenj merged 1 commit intomainfrom
benibenj/disastrous-termite

Conversation

@benibenj
Copy link
Copy Markdown
Contributor

Copilot Generated Description: Remove the secondary sidebar contribution point and associated checks from the codebase.

closes #263786

Copilot AI review requested due to automatic review settings October 27, 2025 16:40
@benibenj benibenj enabled auto-merge October 27, 2025 16:40
@benibenj benibenj self-assigned this Oct 27, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR finalizes the secondary sidebar view contribution point by removing its experimental/proposed API status. The change removes the requirement for extensions to opt into the contribSecondarySidebar proposed API when contributing views to the secondary sidebar (auxiliary bar).

  • Removes the contribSecondarySidebar proposed API declaration
  • Removes the API enablement check when registering secondary sidebar views
  • Removes unused import of checkProposedApiEnabled

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/api/browser/viewsExtensionPoint.ts Removes the proposed API check for secondary sidebar contributions and cleans up the now-unused checkProposedApiEnabled import
src/vs/platform/extensions/common/extensionsApiProposals.ts Removes the contribSecondarySidebar proposed API entry from the registry

@vs-code-engineering vs-code-engineering Bot added this to the October 2025 milestone Oct 27, 2025
@benibenj benibenj merged commit 370ea76 into main Oct 27, 2025
28 checks passed
@benibenj benibenj deleted the benibenj/disastrous-termite branch October 27, 2025 16:52
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize Secondary Sidebar proposed API

3 participants