Don't include ext description in IChatSessionsExtensionPoint#273595
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Oct 27, 2025
Merged
Don't include ext description in IChatSessionsExtensionPoint#273595mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
This isn't part of the contribution so the types are incorrect
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the extensionDescription field from the IChatSessionsExtensionPoint interface, as it was incorrectly included in the contribution type definition. The extension description is not part of the contribution schema itself but is metadata about the extension providing the contribution.
Key Changes:
- Removed
extensionDescriptionfield fromIChatSessionsExtensionPointinterface - Updated internal storage to keep extension metadata separate from contribution data
- Updated all references to access extension metadata through the new storage structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/chatSessionsService.ts |
Removed extensionDescription field and unused import from the IChatSessionsExtensionPoint interface |
src/vs/workbench/contrib/chat/browser/chatSessions.contribution.ts |
Refactored internal storage to separate contribution data from extension metadata, and updated all references throughout the service |
Tyriar
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't part of the contribution so the types are incorrect