remove specific model checks we don't need#275636
Merged
justschen merged 1 commit intomicrosoft:mainfrom Nov 5, 2025
Merged
Conversation
Tyriar
approved these changes
Nov 5, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes model-specific logic for handling bolded content in chat thinking parts. The change makes the bold stripping behavior universal rather than conditional on the model being "codex".
Key Changes
- Removed unused import
isResponseVMfrom chatViewModel - Removed the
modelIdprivate field and its initialization logic - Made bold marker stripping (
**...**) apply to all models instead of only "codex" models
Comment on lines
+168
to
+169
| if (cleanedContent.startsWith('**') && cleanedContent.endsWith('**')) { | ||
| contentToRender = cleanedContent.slice(2, -2); |
There was a problem hiding this comment.
The bold stripping logic is too simplistic and may incorrectly strip valid markdown bold markers. If the content is 'Bold text more', this would incorrectly strip the outer markers leaving 'Bold** text **more' which is malformed markdown. Consider checking that the content doesn't contain any other bold markers between the start and end, or use a more robust regex-based approach to detect if the entire content is a single bold block.
Suggested change
| if (cleanedContent.startsWith('**') && cleanedContent.endsWith('**')) { | |
| contentToRender = cleanedContent.slice(2, -2); | |
| const boldBlockMatch = cleanedContent.match(/^\*\*(.+)\*\*$/s); | |
| if (boldBlockMatch) { | |
| contentToRender = boldBlockMatch[1]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added in as a defensive thing but we don't really need and shouldn't do this