Removing history custom node from agents view#276642
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the custom "History" node from the agents view and replaces it with a more generic grouping mechanism. History items are now placed into a collapsible group node instead of appearing under a special "Show history..." node.
Key Changes:
- Introduced
IChatSessionGroupIteminterface andisGroupNode()helper function to support group nodes in the sessions tree - Added
groupNameproperty toIChatSessionItemto enable grouping - Refactored
SessionsDataSourceto create group nodes from items with agroupNameproperty - Modified
LocalChatSessionsProviderto assign history items to a "History" group instead of creating a special history node - Updated
SessionsRendererto handle rendering of group nodes - Removed special handling for
HISTORY_NODE_IDthroughout the codebase
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Added optional groupName property to IChatSessionItem interface |
| src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsViewPane.ts | Removed chatService parameter from SessionsDataSource constructor and removed special handling for HISTORY_NODE_ID in drag, context menu, and open handlers |
| src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts | Added group node rendering support, refactored SessionsDataSource to create group nodes from grouped items, removed unused imports |
| src/vs/workbench/contrib/chat/browser/chatSessions/localChatSessionsProvider.ts | Replaced history node with actual history items that have groupName: 'History', removed HISTORY_NODE_ID constant |
| src/vs/workbench/contrib/chat/browser/chatSessions/common.ts | Added IChatSessionGroupItem interface and isGroupNode() type guard function |
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsViewPane.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsViewPane.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsViewPane.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/localChatSessionsProvider.ts
Outdated
Show resolved
Hide resolved
…nsViewPane.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
dmitrivMS
reviewed
Nov 11, 2025
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts
Outdated
Show resolved
Hide resolved
dmitrivMS
previously approved these changes
Nov 11, 2025
mjbvz
reviewed
Nov 11, 2025
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts
Outdated
Show resolved
Hide resolved
bpasero
requested changes
Nov 12, 2025
src/vs/workbench/contrib/chat/browser/chatSessions/localChatSessionsProvider.ts
Show resolved
Hide resolved
lszomoru
approved these changes
Nov 12, 2025
bpasero
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.