put save image command into output menu#276835
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "Save Image" command to the output toolbar in notebooks, allowing users to save image outputs directly to disk. The changes include refactoring duplicated code into shared helper functions to improve maintainability.
Key changes:
- Added a new
SaveCellOutputImageActionthat appears in the output toolbar for image mime types - Refactored duplicated code from action classes into shared utility functions (
getNotebookEditorFromContextandgetOutputViewModelFromContext) - Added a new save icon registration for the notebook save action
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| notebookIcons.ts | Registers a new saveIcon for the save image action |
| cellOutputActions.ts | Adds new SaveCellOutputImageAction, refactors duplicated code into utility functions, and updates existing actions to use the shared helpers |
src/vs/workbench/contrib/notebook/browser/controller/cellOutputActions.ts
Show resolved
Hide resolved
justschen
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/vscode-jupyter#17043