Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a hot reload development configuration that enables faster iteration during VS Code workbench development by loading the workbench from a Vite dev server instead of compiled JavaScript files.
Key Changes:
- Introduces
DEV_WINDOW_SRCenvironment variable to specify an alternative URL for loading the workbench window - Adds conditional logic to load TypeScript sources directly when in hot reload mode, bypassing CSS import maps and compiled JS
- Creates new launch configuration "VS Code (Hot Reload)" with supporting HTML and TypeScript entry points
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/windows/electron-main/windowImpl.ts | Adds support for loading window from DEV_WINDOW_SRC environment variable instead of default workbench HTML |
| src/vs/platform/windows/electron-main/types.d.ts | Declares TypeScript type definition for the new DEV_WINDOW_SRC environment variable |
| src/vs/code/electron-browser/workbench/workbench.ts | Modifies workbench loading to conditionally skip CSS import maps and load TypeScript sources directly when DEV_WINDOW_SRC is set |
| src/vs/base/parts/ipc/electron-main/ipcMain.ts | Adds IPC validation bypass for URLs matching DEV_WINDOW_SRC to allow communication from the Vite dev server |
| build/monaco-editor-playground/workbench-vite-electron.html | New HTML entry point for loading workbench through Vite dev server |
| build/monaco-editor-playground/workbench-electron.ts | New TypeScript entry point that imports setup and workbench modules for hot reload |
| .vscode/launch.json | Renames and updates launch configuration from "Dev Debug" to "Hot Reload", adds DEV_WINDOW_SRC environment variable and preLaunchTask |
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
|
bpasero
requested changes
Nov 14, 2025
Member
Author
|
@copilot can you implement all the feedback from ben? |
Contributor
bpasero
approved these changes
Nov 21, 2025
Member
|
@hediet carved out some time to review, pushed some 💄 , feel free to merge. |
dmitrivMS
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.