Remove another sessionId usage#277295
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Nov 14, 2025
Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR continues the migration from sessionId (string-based) to sessionResource (URI-based) identifiers in the chat feature, addressing issue #274403. The changes deprecate the sessionId property in the IChatAgentRequest interface and update the ChatInputPart component to use URI-based session tracking.
- Deprecates
sessionIdinIChatAgentRequestinterface with proper JSDoc annotation - Migrates
_lastEditingSessionIdto_lastEditingSessionResourceinChatInputPart - Updates session comparison logic from string equality to URI equality using
isEqual()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatAgents.ts | Adds deprecation comment to sessionId property, directing developers to use sessionResource instead |
| src/vs/workbench/contrib/chat/browser/chatInputPart.ts | Refactors tracking of editing sessions from string-based IDs to URI-based resources, including variable rename and proper URI comparison |
Tyriar
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #274403