Fix broken checkall in quick pick#281415
Merged
TylerLeonhardt merged 1 commit intomainfrom Dec 5, 2025
Merged
Conversation
This line shouldn't have been there because the visible count container is something that is rendered off screen. Fixes #281176
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the quick pick's "checkall" functionality was broken due to incorrect styling applied to an off-screen accessibility element. The issue was that the visibleCountContainer (an element positioned off-screen for screen reader accessibility) was having its right style property incorrectly modified based on the number of toggles, when it should only be positioned off-screen at left: -10000px.
Key Changes
- Removed incorrect positioning logic for the
visibleCountContainerelement that was interfering with the quick pick checkall functionality
dmitrivMS
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line shouldn't have been there because the visible count container is something that is rendered off screen.
Fixes #281176