Revert "Revert "debt - remove AMD support of VSCode for web"" #286423
+186
−367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84ce6e1.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-applies changes to remove AMD (Asynchronous Module Definition) support from VSCode for web, reverting a previous revert. The changes streamline the web workbench entry point architecture by removing the AMD-to-ESM bridge and consolidating module loading.
Key changes:
- Removed AMD bridge code and converted
workbench.web.main.tsto use direct ESM imports and registrations - Restructured
workbench.web.main.internal.tsto import fromworkbench.web.main.tsand maintain public API exports - Simplified NLS (localization) implementation by consolidating functions directly in
nls.tsand removingnls.messages.ts - Updated build configuration, ESLint rules, and CI/CD pipelines to reflect the new entry point structure
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/workbench.web.main.ts | Replaced AMD bridge wrapper with direct ESM imports, service registrations, and workbench contributions |
| src/vs/workbench/workbench.web.main.internal.ts | Simplified to import workbench.web.main.js and re-export public API for web embedders |
| src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusEntry.ts | Added optional chaining to safely access product.defaultChatAgent.completionsEnablementSetting |
| src/vs/nls.ts | Moved getNLSMessages and getNLSLanguage implementations directly into this file |
| src/vs/nls.messages.ts | Removed file (functionality moved to nls.ts) |
| eslint.config.js | Removed workbench.web.main.ts and workbench.web.main.internal.ts from no-standalone-editor exclusions; updated import pattern to workbench.web.main.js; removed loader.d.ts and nls.messages.ts from code-import-patterns target |
| build/lib/optimize.ts | Removed special banner handling for workbench.web.main entry point |
| build/gulpfile.vscode.web.ts | Removed VinylFile import and AMD bridge-related file transformation logic |
| build/buildfile.ts | Changed workbenchWeb entry point from workbench.web.main to workbench.web.main.internal |
| build/azure-pipelines/web/product-build-web.yml | Removed separate sourcemap upload step for workbench.web.main.js.map; consolidated to single upload for workbench.web.main.internal.js.map |
Tyriar
approved these changes
Jan 7, 2026
joshspicer
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #286421
Did a revert so that it's not included in this week's release, we want to give partners time to validate before removing AMD