Skip to content

watcher - update to latest version#286484

Merged
bpasero merged 3 commits intomainfrom
ben/broken-termite
Jan 9, 2026
Merged

watcher - update to latest version#286484
bpasero merged 3 commits intomainfrom
ben/broken-termite

Conversation

@bpasero
Copy link
Copy Markdown
Member

@bpasero bpasero commented Jan 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 8, 2026 05:59
@bpasero bpasero self-assigned this Jan 8, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/linux/verify-glibc-requirements.sh

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates from the VS Code fork @vscode/watcher (bpasero/watcher) to the upstream @parcel/watcher package, updating to commit 5389ccbee4407991b77b35da876444c0f40f0a88 from the official parcel-bundler/watcher repository.

Key Changes:

  • Replaced all import statements from @vscode/watcher to @parcel/watcher across TypeScript and JavaScript files
  • Updated package dependencies in package.json files to reference the upstream repository
  • Updated build scripts, configuration files, and tooling to reflect the new package name

Reviewed changes

Copilot reviewed 13 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/platform/files/node/watcher/parcel/parcelWatcher.ts Updated import statement to use @parcel/watcher
src/vs/platform/environment/test/node/nativeModules.integrationTest.ts Updated test to import and verify @parcel/watcher instead of the VS Code fork
scripts/playground-server.ts Updated import statement for file watching functionality
remote/package.json Replaced dependency reference to upstream parcel-bundler/watcher repository
remote/package-lock.json Updated lock file entries for new package
package.json Replaced dependency reference to upstream parcel-bundler/watcher repository
package-lock.json Updated lock file entries for new package
extensions/package.json Updated devDependency to reference upstream repository
extensions/package-lock.json Updated lock file entries for new package
extensions/esbuild-webview-common.mjs Updated import for watch functionality in build script
eslint.config.js Updated ESLint configuration to allow @parcel/watcher and @parcel/* imports in appropriate contexts
build/npm/postinstall.ts Updated paths to search for @parcel instead of @vscode for watcher prebuilt modules
build/gulpfile.vscode.ts Updated glob ignore pattern for watcher modules
build/darwin/create-universal-app.ts Updated path reference (contains critical bug)
build/azure-pipelines/linux/verify-glibc-requirements.sh Updated path to exclude @parcel/watcher from glibc verification
build/.moduleignore Updated ignore patterns for the new package name
Files not reviewed (2)
  • extensions/package-lock.json: Language not supported
  • remote/package-lock.json: Language not supported

Comment thread build/darwin/create-universal-app.ts Outdated
lszomoru
lszomoru previously approved these changes Jan 8, 2026
@lszomoru
Copy link
Copy Markdown
Member

lszomoru commented Jan 8, 2026

@bpasero, PR build is 🔴

Comment thread build/darwin/create-universal-app.ts
mjbvz
mjbvz previously approved these changes Jan 8, 2026
@deepak1556
Copy link
Copy Markdown
Collaborator

@rzhao271 -D_FORTIFY_SOURCE breaks building with our sysroots see #286497, I don't see a way to keep it. Please remove the flag from the modules to unblock regular module consumption. Can you create a separate tracking issue to bring back the flag (if we can find a way to make it work with sysroots otherwise we need an exception).

@bpasero bpasero merged commit fe665a9 into main Jan 9, 2026
22 checks passed
@bpasero bpasero deleted the ben/broken-termite branch January 9, 2026 06:07
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants