Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
There was a problem hiding this comment.
Pull request overview
This pull request migrates from the VS Code fork @vscode/watcher (bpasero/watcher) to the upstream @parcel/watcher package, updating to commit 5389ccbee4407991b77b35da876444c0f40f0a88 from the official parcel-bundler/watcher repository.
Key Changes:
- Replaced all import statements from
@vscode/watcherto@parcel/watcheracross TypeScript and JavaScript files - Updated package dependencies in package.json files to reference the upstream repository
- Updated build scripts, configuration files, and tooling to reflect the new package name
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/files/node/watcher/parcel/parcelWatcher.ts | Updated import statement to use @parcel/watcher |
| src/vs/platform/environment/test/node/nativeModules.integrationTest.ts | Updated test to import and verify @parcel/watcher instead of the VS Code fork |
| scripts/playground-server.ts | Updated import statement for file watching functionality |
| remote/package.json | Replaced dependency reference to upstream parcel-bundler/watcher repository |
| remote/package-lock.json | Updated lock file entries for new package |
| package.json | Replaced dependency reference to upstream parcel-bundler/watcher repository |
| package-lock.json | Updated lock file entries for new package |
| extensions/package.json | Updated devDependency to reference upstream repository |
| extensions/package-lock.json | Updated lock file entries for new package |
| extensions/esbuild-webview-common.mjs | Updated import for watch functionality in build script |
| eslint.config.js | Updated ESLint configuration to allow @parcel/watcher and @parcel/* imports in appropriate contexts |
| build/npm/postinstall.ts | Updated paths to search for @parcel instead of @vscode for watcher prebuilt modules |
| build/gulpfile.vscode.ts | Updated glob ignore pattern for watcher modules |
| build/darwin/create-universal-app.ts | Updated path reference (contains critical bug) |
| build/azure-pipelines/linux/verify-glibc-requirements.sh | Updated path to exclude @parcel/watcher from glibc verification |
| build/.moduleignore | Updated ignore patterns for the new package name |
Files not reviewed (2)
- extensions/package-lock.json: Language not supported
- remote/package-lock.json: Language not supported
|
@bpasero, PR build is 🔴 |
|
@rzhao271 |
No description provided.