Conversation
dmitrivMS
approved these changes
Jan 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated "v1" implementation of inline chat, consolidating to a single "v2" implementation. The changes include:
- Deletion of old test files, utilities, strategies, and session management code
- Renaming
InlineChatController2→InlineChatControllerandAbstractInline2ChatAction→AbstractInlineChatAction - Simplification of session service API (removing methods like
createSession,moveSession,stashSession) - Removal of v1-specific actions and UI components
- Updates to imports and references throughout the codebase
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| terminalChatActions.ts | Updated import from AbstractInline1ChatAction to AbstractInlineChatAction |
| inlineChatStrategies.test.ts | Deleted - old v1 test file |
| inlineChatSession.test.ts | Deleted - old v1 test file |
| inlineChatController.test.ts | Deleted - old v1 test file |
| inlineChatActions.ts | Removed import from deprecated class name, renamed v2 to main class |
| utils.ts | Deleted - old v1 utility code |
| inlineChatWidget.ts | Removed accessible diff viewer code for v1 |
| inlineChatStrategies.ts | Deleted - old v1 strategy implementation |
| inlineChatSessionServiceImpl.ts | Simplified to remove v1 session management |
| inlineChatSessionService.ts | Removed v1 API methods, renamed v2 methods |
| inlineChatSession.ts | Deleted - old v1 session classes |
| inlineChatNotebook.ts | Removed v1 session key computer registration |
| inlineChatController.ts | Consolidated controllers, removed v1 implementation |
| inlineChatActions.ts | Removed v1 actions, renamed v2 classes |
| inlineChatAccessibleView.ts | Deleted - old v1 accessible view |
| inlineChat.contribution.ts | Updated registrations to single controller |
| emptyTextEditorHint.ts | Updated to use new session API |
| chatService.ts | Removed unused properties from location data |
| chatEditingEditorContextKeys.ts | Updated to use renamed session method |
| chatExecuteActions.ts | Removed delegate to edit session action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #282015