Skip to content

debt - remove old inline chat world#286503

Merged
jrieken merged 1 commit intomainfrom
joh/static-bat
Jan 8, 2026
Merged

debt - remove old inline chat world#286503
jrieken merged 1 commit intomainfrom
joh/static-bat

Conversation

@jrieken
Copy link
Copy Markdown
Member

@jrieken jrieken commented Jan 8, 2026

fixes #282015

Copilot AI review requested due to automatic review settings January 8, 2026 09:53
@jrieken jrieken enabled auto-merge (squash) January 8, 2026 09:53
@jrieken jrieken self-assigned this Jan 8, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated "v1" implementation of inline chat, consolidating to a single "v2" implementation. The changes include:

  • Deletion of old test files, utilities, strategies, and session management code
  • Renaming InlineChatController2InlineChatController and AbstractInline2ChatActionAbstractInlineChatAction
  • Simplification of session service API (removing methods like createSession, moveSession, stashSession)
  • Removal of v1-specific actions and UI components
  • Updates to imports and references throughout the codebase

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
terminalChatActions.ts Updated import from AbstractInline1ChatAction to AbstractInlineChatAction
inlineChatStrategies.test.ts Deleted - old v1 test file
inlineChatSession.test.ts Deleted - old v1 test file
inlineChatController.test.ts Deleted - old v1 test file
inlineChatActions.ts Removed import from deprecated class name, renamed v2 to main class
utils.ts Deleted - old v1 utility code
inlineChatWidget.ts Removed accessible diff viewer code for v1
inlineChatStrategies.ts Deleted - old v1 strategy implementation
inlineChatSessionServiceImpl.ts Simplified to remove v1 session management
inlineChatSessionService.ts Removed v1 API methods, renamed v2 methods
inlineChatSession.ts Deleted - old v1 session classes
inlineChatNotebook.ts Removed v1 session key computer registration
inlineChatController.ts Consolidated controllers, removed v1 implementation
inlineChatActions.ts Removed v1 actions, renamed v2 classes
inlineChatAccessibleView.ts Deleted - old v1 accessible view
inlineChat.contribution.ts Updated registrations to single controller
emptyTextEditorHint.ts Updated to use new session API
chatService.ts Removed unused properties from location data
chatEditingEditorContextKeys.ts Updated to use renamed session method
chatExecuteActions.ts Removed delegate to edit session action

@jrieken jrieken merged commit 7419543 into main Jan 8, 2026
27 of 28 checks passed
@jrieken jrieken deleted the joh/static-bat branch January 8, 2026 10:12
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move off and remove InlineChatController1

3 participants