Add Session target picker actions #287143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benibenj
changed the title
Contributor
Author
Code_-_Insiders_XYi8RIJ1Fm.mp4 |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a session target picker for the chat interface, enabling users to switch between different chat session types (Local, Background, Cloud). The PR also refactors code to use a more generic naming convention for input picker components.
Changes:
- Adds
SessionTargetPickerActionItemclass andOpenSessionTargetPickerActionto allow users to select chat session targets - Renames CSS classes from
chat-modelPicker-*tochat-input-picker-*for consistency across all picker types - Refactors session opening logic into reusable helper functions to eliminate code duplication
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/inlineChat/browser/media/inlineChat.css | Updates CSS class name from chat-modelPicker-item to chat-input-picker-item |
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Renames CSS classes to use generic chat-input-picker naming and adds disabled state styling for picker items |
| src/vs/workbench/contrib/chat/browser/widget/input/sessionTargetPickerActionItem.ts | New file implementing the session target picker UI component |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts | Updates CSS class references to use new chat-input-picker naming |
| src/vs/workbench/contrib/chat/browser/widget/input/modePickerActionItem.ts | Updates CSS class references to use new chat-input-picker naming |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Integrates session target picker widget and updates imports |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts | Adds dynamic action registration for session providers and refactors duplicate session opening code into shared helper functions |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.ts | Adds getAgentSessionProvider helper function to convert URI or string to AgentSessionProviders enum |
| src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts | Adds OpenSessionTargetPickerAction and exports OpenModelPickerAction class |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jriekenMatched files:
|
bpasero
previously approved these changes
Jan 14, 2026
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
@benibenj the one feedback I would have is that if the picker is disabled, maybe it should just shrink to only showing the icon and on hover you get some more info why its disabled? It could also shout out to the keybinding for how to create a new Chat of the same type.
lszomoru
approved these changes
Jan 14, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
* first round * icons * nits * Agent type picker and improved new chat actions --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce a new chat input picker and session target picker actions, along with necessary UI updates and styling changes. Update relevant imports and class names to reflect the new picker functionality.#284091