make PersistModelChoice an experimental setting
#287528
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the PersistModelChoice setting an experimental setting by adding an experiment property with mode 'auto'. This allows the setting's default value to be controlled by experimentation infrastructure, enabling gradual rollout or A/B testing of the feature.
Changes:
- Added
experiment: { mode: 'auto' }to thePersistModelChoiceconfiguration setting
| description: localize('persistModelChoice', "Whether to persist the selected language model choice across inline chat sessions. The default is not to persist and to use the vendor's default model for inline chat because that yields the best experience."), | ||
| default: false, | ||
| type: 'boolean' | ||
| type: 'boolean', |
There was a problem hiding this comment.
When adding the experiment property to a configuration setting, it's a common pattern in the codebase to also add a tags property with 'experimental' or 'preview'. Looking at other settings in the same file (EnableV2 has both tags: ['preview'] and experiment, notebookAgent has both tags: ['experimental'] and experiment), and examining patterns in other files like editorConfigurationSchema.ts and chat.contribution.ts, settings with experiment configurations typically include a tags array. Consider adding tags: ['experimental'] to make this setting consistent with similar experimental settings in the codebase.
| type: 'boolean', | |
| type: 'boolean', | |
| tags: ['experimental'], |
No description provided.