Skip to content

fix confirmation widget appearing inside reasoning #288494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justschen merged 3 commits into from
Jan 16, 2026
Merged

fix confirmation widget appearing inside reasoning #288494

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abd38d5
double check if our tool has confirmations after streaming
justschen Jan 16, 2026
a25b1a3
fix package.json
justschen Jan 16, 2026
b51b92a
fix again
justschen Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,6 +1315,10 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
}

if (part.kind === 'toolInvocation') {
// pin when streaming since we don't know if we have confirmation yet or not
if (IChatToolInvocation.isStreaming(part)) {
return true;
}
return !IChatToolInvocation.getConfirmationMessages(part);
}

Expand Down Expand Up @@ -1693,6 +1697,27 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
if (lastThinking && part?.domNode && toolInvocation.presentation !== 'hidden') {
lastThinking.appendItem(part?.domNode, toolInvocation.toolId, toolInvocation, templateData.value);
lastThinking.addDisposable(part);

// watch for streaming -> confirmation transition to finalize thinking
if (toolInvocation.kind === 'toolInvocation' && IChatToolInvocation.isStreaming(toolInvocation)) {
let wasStreaming = true;
part.addDisposable(autorun(reader => {
const state = toolInvocation.state.read(reader);
if (wasStreaming && state.type !== IChatToolInvocation.StateKind.Streaming) {
wasStreaming = false;
if (state.type === IChatToolInvocation.StateKind.WaitingForConfirmation) {
if (part.domNode) {
const wrapper = part.domNode.parentElement;
if (wrapper?.classList.contains('chat-thinking-tool-wrapper')) {
wrapper.remove();
}
templateData.value.appendChild(part.domNode);
}
this.finalizeCurrentThinkingPart(context, templateData);
}
}
}));
Comment thread
justschen marked this conversation as resolved.
}
}
} else {
this.finalizeCurrentThinkingPart(context, templateData);
Expand Down
Loading