Adjust chat-current-response-min-height behavior #288674
Merged
+28
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only show the request/response, don't show any of the previous response. This looks cleaner, part of #274099. Also, measuring from the top means that we don't shift the response up and down when expanding the list of edited files (if the response is shorter than the minimum)
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the behavior of the chat widget's current response minimum height calculation. Instead of using a fixed percentage of the content height (75%), it now calculates the min height dynamically based on the second-to-last item's rendered height. This ensures only the current request/response pair is visible without showing previous responses.
Changes:
- Extracted the min height calculation logic into a new
updateLastItemMinHeight()method - Added an event handler to update min height when the second-to-last item's height changes
- Refactored the
layout()method to call the newupdateLastItemMinHeight()method
dmitrivMS
approved these changes
Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show the request/response, don't show any of the previous response. This looks cleaner, part of #274099. Also, measuring from the top means that we don't shift the response up and down when expanding the list of edited files (if the response is shorter than the minimum)