remote cli: do not open files with openExternal #288856
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where the remote CLI incorrectly attempted to open file:// URIs using the openExternal command, which would fail since these URIs refer to the remote machine's file system and have no meaning on the local machine.
Changes:
- Modified the
openExternalmethod to skip file:// URIs instead of attempting to open them - Simplified the logic by always passing the string representation of URIs to the command handler
| const urioOpen = uri.scheme === 'file' ? uri : uriString; // workaround for #112577 | ||
| await this._commands.executeCommand('_remoteCLI.openExternal', urioOpen); | ||
| if (uri.scheme === 'file') { | ||
| // skip file:// uris, they refer to the file system of the remote that have no meaning on the local machine |
There was a problem hiding this comment.
The comment has a grammatical error. It should read "they refer to the file system of the remote and have no meaning on the local machine" instead of "they refer to the file system of the remote that have no meaning on the local machine".
Suggested change
| // skip file:// uris, they refer to the file system of the remote that have no meaning on the local machine | |
| // skip file:// uris, they refer to the file system of the remote and have no meaning on the local machine |
ulugbekna
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/6608