fix review comments #288913
Merged
fix review comments #288913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulugbekna
approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses review feedback from PR #288902 by fixing two issues in test files: a bug with an incorrect parameter in a map callback and a typo in a comment.
Changes:
- Removed an extraneous fourth parameter from an Array.map callback in promptsService.test.ts
- Corrected a spelling error in a comment from "fro" to "from" in promptHeaderAutocompletion.test.ts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/promptSyntax/service/promptsService.test.ts | Fixed bug by removing incorrect fourth parameter (undefined) from map callback |
| src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHeaderAutocompletion.test.ts | Corrected spelling typo in comment from "fro" to "from" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #288902