Skip to content

Conversation

@pwang347
Copy link
Member

@pwang347 pwang347 commented Jan 20, 2026

image

Copilot AI review requested due to automatic review settings January 20, 2026 22:41
@pwang347 pwang347 marked this pull request as ready for review January 20, 2026 22:44
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the chat prompt files provider API to use a proper virtual file system (vscode-chat-prompt) for inline prompt content, enabling consumers (including extensions) to read prompt content via the standard file APIs.

Changes:

  • Expands the proposed prompt resource descriptor typing and updates ext host types accordingly.
  • Introduces a vscode-chat-prompt file system provider backed by the in-memory prompt content store.
  • Adds supporting plumbing: URI normalization for content lookup, an internal command to list extension prompt files, and markdown sanitization allowance for the new scheme.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/vscode-dts/vscode.proposed.chatPromptFiles.d.ts Updates proposed API types so chat resources use a unified descriptor shape.
src/vs/workbench/contrib/chat/common/promptSyntax/chatPromptFilesContribution.ts Adds an internal command to enumerate extension-contributed prompt files.
src/vs/workbench/contrib/chat/common/promptSyntax/chatPromptContentStore.ts Normalizes vscode-chat-prompt URIs for stable content lookup across metadata variants.
src/vs/workbench/contrib/chat/browser/promptSyntax/chatPromptFileSystemProvider.ts Adds an IFileSystemProvider for vscode-chat-prompt URIs to support workspace.fs reads.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Ensures the new provider module is loaded/registered in the workbench.
src/vs/workbench/api/common/extHostTypes.ts Aligns ext host wrapper types with the updated resource descriptor type.
src/vs/workbench/api/common/extHostChatAgents2.ts Generates typed virtual URIs for inline prompt content and converts descriptors to IPC resources.
src/vs/base/browser/markdownRenderer.ts Allows vscode-chat-prompt links through markdown sanitization.

@pwang347 pwang347 marked this pull request as draft January 20, 2026 22:54
@pwang347 pwang347 marked this pull request as ready for review January 20, 2026 23:44
@pwang347 pwang347 enabled auto-merge (squash) January 20, 2026 23:53
@pwang347 pwang347 marked this pull request as draft January 21, 2026 00:00
auto-merge was automatically disabled January 21, 2026 00:00

Pull request was converted to draft

@pwang347 pwang347 marked this pull request as ready for review January 21, 2026 00:25
@pwang347 pwang347 enabled auto-merge (squash) January 21, 2026 00:25
@pwang347 pwang347 merged commit 0ab69cd into main Jan 21, 2026
22 checks passed
@pwang347 pwang347 deleted the pawang/promptFileProviderUpdate branch January 21, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants