Fix navigation to localhost:<port> in integrated browser
#289253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kycutler
commented
Jan 20, 2026
kycutler
commented
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where navigating to localhost:<port> URLs in the integrated browser failed due to URL parsing treating "localhost" as the protocol instead of the hostname.
Changes:
- Added special-case handling to prepend "http://" to localhost URLs before the general protocol check
- Updated comment to explain the localhost special case
jruales
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.