-
Notifications
You must be signed in to change notification settings - Fork 37.6k
refactor(inlineChat): rename overlay widget classes and update references #289419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andling and styling
…utOverlayWidget and update references
…nces feat(inlineChat): enhance overlay widget positioning and visibility handling fix(inlineChat): adjust CSS for session overlay progress message
a5ca15d to
61e55c3
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the inline chat overlay widget architecture to improve positioning and visibility handling. The main changes include:
Changes:
- Splits
InlineChatOverlayWidgetinto two specialized widgets:InlineChatInputWidget(for user input) andInlineChatSessionOverlayWidget(for progress display during requests) - Implements line-based positioning with automatic scroll tracking and visibility management
- Extracts shared
ChatEditingAcceptRejectActionViewItemclass for reuse across inline chat and chat editing features - Updates CSS styling for the new session overlay widget with pulse animations and consistent theming
- Adds hover mode context key for conditional UI rendering based on render mode configuration
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
inlineChatOverlayWidget.ts |
Splits overlay widget into InlineChatInputWidget and InlineChatSessionOverlayWidget, adds scroll tracking and line-based positioning |
inlineChatSessionOverlay.css |
New CSS file defining styles for the session overlay widget with busy states and animations |
inlineChatEditorAffordance.css |
Updates affordance styling with dynamic height based on line height |
inlineChat.ts |
Adds CTX_HOVER_MODE context key for render mode detection |
inlineChatController.ts |
Integrates both new overlay widgets and manages their visibility based on session state |
inlineChatAffordance.ts |
Updates to use new InlineChatInputWidget class and improved positioning logic |
inlineChatGutterAffordance.ts |
Adds hover tooltip with keybinding and updates menu data structure |
inlineChatEditorAffordance.ts |
Implements beforeRender to set CSS custom property for dynamic sizing |
inlineChatActions.ts |
Adds new UndoSessionAction2 for hover mode and updates action preconditions |
inlineChat.contribution.ts |
Removes unused gutter menu registrations and context key usage |
chatEditingEditorOverlay.ts |
Extracts ChatEditingAcceptRejectActionViewItem as public class for reuse |
chatEditingEditorActions.ts |
Adds toggle diff action to inline execute menu in hover mode |
chatExecuteActions.ts |
Updates cancel action menu conditions for inline chat integration |
debugEditorActions.ts |
Removes gutter-specific debug menu items |
editorBrowser.ts |
Adds isIOverlayWidgetPositionCoordinates type guard function |
actionbar.ts |
Adds isFocused method to check focus state of action bar items |
gutterIndicatorView.ts |
Changes _hoverService visibility to protected for subclass access |
vscode-known-variables.json |
Adds --vscode-inline-chat-affordance-height CSS variable |
src/vs/workbench/contrib/inlineChat/browser/media/inlineChatSessionOverlay.css
Show resolved
Hide resolved
src/vs/workbench/contrib/inlineChat/browser/media/inlineChatSessionOverlay.css
Outdated
Show resolved
Hide resolved
…ssionOverlay.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dmitrivMS
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(inlineChat): enhance overlay widget positioning and visibility handling fix(inlineChat): adjust CSS for session overlay progress message