Skip to content

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Jan 21, 2026

feat(inlineChat): enhance overlay widget positioning and visibility handling fix(inlineChat): adjust CSS for session overlay progress message

Copilot AI review requested due to automatic review settings January 21, 2026 15:55
@jrieken jrieken self-assigned this Jan 21, 2026
…nces

feat(inlineChat): enhance overlay widget positioning and visibility handling
fix(inlineChat): adjust CSS for session overlay progress message
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the inline chat overlay widget architecture to improve positioning and visibility handling. The main changes include:

Changes:

  • Splits InlineChatOverlayWidget into two specialized widgets: InlineChatInputWidget (for user input) and InlineChatSessionOverlayWidget (for progress display during requests)
  • Implements line-based positioning with automatic scroll tracking and visibility management
  • Extracts shared ChatEditingAcceptRejectActionViewItem class for reuse across inline chat and chat editing features
  • Updates CSS styling for the new session overlay widget with pulse animations and consistent theming
  • Adds hover mode context key for conditional UI rendering based on render mode configuration

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
inlineChatOverlayWidget.ts Splits overlay widget into InlineChatInputWidget and InlineChatSessionOverlayWidget, adds scroll tracking and line-based positioning
inlineChatSessionOverlay.css New CSS file defining styles for the session overlay widget with busy states and animations
inlineChatEditorAffordance.css Updates affordance styling with dynamic height based on line height
inlineChat.ts Adds CTX_HOVER_MODE context key for render mode detection
inlineChatController.ts Integrates both new overlay widgets and manages their visibility based on session state
inlineChatAffordance.ts Updates to use new InlineChatInputWidget class and improved positioning logic
inlineChatGutterAffordance.ts Adds hover tooltip with keybinding and updates menu data structure
inlineChatEditorAffordance.ts Implements beforeRender to set CSS custom property for dynamic sizing
inlineChatActions.ts Adds new UndoSessionAction2 for hover mode and updates action preconditions
inlineChat.contribution.ts Removes unused gutter menu registrations and context key usage
chatEditingEditorOverlay.ts Extracts ChatEditingAcceptRejectActionViewItem as public class for reuse
chatEditingEditorActions.ts Adds toggle diff action to inline execute menu in hover mode
chatExecuteActions.ts Updates cancel action menu conditions for inline chat integration
debugEditorActions.ts Removes gutter-specific debug menu items
editorBrowser.ts Adds isIOverlayWidgetPositionCoordinates type guard function
actionbar.ts Adds isFocused method to check focus state of action bar items
gutterIndicatorView.ts Changes _hoverService visibility to protected for subclass access
vscode-known-variables.json Adds --vscode-inline-chat-affordance-height CSS variable

jrieken and others added 2 commits January 21, 2026 17:06
…ssionOverlay.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jrieken jrieken marked this pull request as ready for review January 21, 2026 16:15
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 21, 2026
@jrieken jrieken merged commit eca2264 into main Jan 21, 2026
22 checks passed
@jrieken jrieken deleted the joh/decent-crab branch January 21, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants