Update conditional breakpoint list dynamically when breakpoints change #289429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>
Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>
Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix conditional breakpoint list not updating dynamically
Update conditional breakpoint list dynamically when breakpoints change
Jan 21, 2026
connor4312
approved these changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds dynamic updates to the conditional breakpoint "Wait for Breakpoint" dropdown list, ensuring it reflects breakpoint changes in real-time without requiring the widget to be closed and reopened.
Changes:
- Extended the existing breakpoint change listener to update the trigger breakpoint dropdown when changes occur
- Refactored breakpoint option building into a reusable
buildBreakpointOptions()method - Added
updateTriggerBreakpointList()to refresh the SelectBox while preserving user selection
Comment on lines
+309
to
+332
| private buildBreakpointOptions(): ISelectOptionItem[] { | ||
| const breakpointOptions: ISelectOptionItem[] = [ | ||
| { text: nls.localize('noTriggerByBreakpoint', 'None'), isDisabled: true }, | ||
| ...this.availableBreakpoints.map(bp => ({ | ||
| text: `${this.labelService.getUriLabel(bp.uri, { relative: true })}: ${bp.lineNumber}`, | ||
| description: nls.localize('triggerByLoading', 'Loading...') | ||
| })), | ||
| ]; | ||
|
|
||
| // Load the source code for each breakpoint asynchronously | ||
| for (const [i, bp] of this.availableBreakpoints.entries()) { | ||
| this.textModelService.createModelReference(bp.uri).then(ref => { | ||
| try { | ||
| breakpointOptions[i + 1].description = ref.object.textEditorModel.getLineContent(bp.lineNumber).trim(); | ||
| } finally { | ||
| ref.dispose(); | ||
| } | ||
| }).catch(() => { | ||
| breakpointOptions[i + 1].description = nls.localize('noBpSource', 'Could not load source.'); | ||
| }); | ||
| } | ||
|
|
||
| return breakpointOptions; | ||
| } |
There was a problem hiding this comment.
The buildBreakpointOptions method has async operations that mutate option descriptions after the array is returned. While the SelectBox's lazy dropdown rendering will eventually show updated descriptions, there's a race condition: if a user opens the dropdown before async operations complete, they'll see "Loading..." descriptions. Consider awaiting all async operations before returning, or using a mechanism to notify when descriptions are ready.
roblourens
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Wait for Breakpoint" dropdown in the conditional breakpoint widget builds its list once on creation and never updates. Adding/removing breakpoints while the widget is open requires closing and reopening to see changes.
Changes
onDidChangeBreakpointslistener to callupdateTriggerBreakpointList()when in trigger point contextbuildBreakpointOptions()for reuseupdateTriggerBreakpointList()method refreshes SelectBox options while preserving current selection (or clearing it if the selected breakpoint was removed)Implementation
The SelectBox already supports dynamic updates via
setOptions(options, selectedIndex). Track available breakpoints inavailableBreakpointsarray and rebuild options on:Selection preservation uses breakpoint ID comparison to maintain UX continuity across updates.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.