tool picker alternative position #289671
Merged
tool picker alternative position #289671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an experimental feature that allows the Configure Tools action to be displayed as a toolbar button within the mode picker dropdown (on hover/focus) as an alternative to showing it in the chat input toolbar. The feature is controlled by the chat.alternativeToolAction.enabled configuration setting.
Changes:
- Adds configuration flag
chat.alternativeToolAction.enabled(experimental, default: false) - Adds toolbar action support to the action widget dropdown UI component
- Updates Configure Tools action menu visibility based on the configuration flag
- Refactors argument extraction in ConfigureToolsAction for better code organization
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/constants.ts | Adds AlternativeToolAction configuration constant |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Registers the experimental configuration setting with description |
| src/vs/workbench/contrib/chat/browser/widget/input/modePickerActionItem.ts | Adds toolbar action to Agent mode items in dropdown when feature enabled |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPickerActionItem.ts | Adds actionContext field to picker options interface |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Passes widget context to picker options for command execution |
| src/vs/workbench/contrib/chat/browser/actions/chatToolActions.ts | Updates menu visibility condition and refactors argument extraction into helper methods |
| src/vs/platform/actionWidget/browser/actionWidgetDropdown.ts | Adds toolbarActions field to action interface and passes it through |
| src/vs/platform/actionWidget/browser/actionList.ts | Implements toolbar rendering with proper disposal and hover handling |
| src/vs/platform/actionWidget/browser/actionWidget.css | Adds CSS rules for showing/hiding toolbar on hover/focus |
| const toolbarActions: IAction[] = []; | ||
| if (alternativeToolActionEnabled && mode.kind === ChatModeKind.Agent && !isDisabledViaPolicy) { | ||
| // Add toolbar actions for Agent modes when alternative tool action is enabled | ||
| const label = localize('configureToolsFor', "Configure tools for {0} {1}", mode.label.get(), isModeConsideredBuiltIn(mode, this._productService) ? 'mode' : 'agent'); |
There was a problem hiding this comment.
The label construction may result in awkward phrasing like "Configure tools for Custom Agent agent" when the mode label already includes "Agent". Consider checking if the mode label already contains the word being appended, or rephrase to avoid redundancy.
Suggested change
| const label = localize('configureToolsFor', "Configure tools for {0} {1}", mode.label.get(), isModeConsideredBuiltIn(mode, this._productService) ? 'mode' : 'agent'); | |
| const isBuiltIn = isModeConsideredBuiltIn(mode, this._productService); | |
| const label = isBuiltIn | |
| ? localize('configureToolsForMode', "Configure tools for {0} mode", mode.label.get()) | |
| : localize('configureToolsForAgent', "Configure tools for {0}", mode.label.get()); |
hediet
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce an alternative tool action that displays the Configure Tools action in the mode picker dropdown on hover. This change includes updates to the configuration, UI elements, and action handling to support the new functionality.