Fix some missing tool calls from thinking/subagent blocks #289738
Merged
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justschen
approved these changes
Jan 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a rendering issue where tool calls could be lost in thinking/subagent blocks when content was not yet expanded. The fix introduces an early initialization mechanism that ensures DOM elements are ready to receive content updates even before the user expands the collapsible section.
Changes:
- Added a
shouldInitEarly()hook toChatCollapsibleContentPartto allow subclasses to initialize content before expansion - Implemented early initialization in
ChatThinkingContentPartfor fixed scrolling mode - Implemented early initialization in
ChatSubagentContentPartwhen actively streaming - Added null safety checks for
textContainerinChatThinkingContentPartto handle cases where it may not be initialized
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| chatCollapsibleContentPart.ts | Added shouldInitEarly() hook that allows subclasses to trigger content initialization before expansion |
| chatThinkingContentPart.ts | Implemented shouldInitEarly() to return true for fixed scrolling mode and added null checks for textContainer access |
| chatSubagentContentPart.ts | Implemented shouldInitEarly() to return true when not initially complete (actively streaming) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.