Skip to content

Conversation

@DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Jan 22, 2026

Screenshot 2026-01-23 at 10 40 34

Copilot AI review requested due to automatic review settings January 22, 2026 23:39
@DonJayamanne DonJayamanne self-assigned this Jan 22, 2026
@DonJayamanne DonJayamanne changed the title Add comments to chat agent input group options Add commands to chat agent input group options Jan 22, 2026
@DonJayamanne
Copy link
Contributor Author

@osortega /cc

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for custom commands in chat agent input group options, allowing extensions to display additional commands at the bottom of the option group picker UI.

Changes:

  • Added commands property to the VS Code API ChatSessionProviderOptionGroup interface for extensibility
  • Created internal IChatSessionProviderOptionGroupCommand interface to represent commands
  • Updated visibility logic to consider commands when determining if an option group should be shown
  • Implemented command rendering in the picker UI with proper separation from option items

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts Added commands property to API interface for option groups
src/vs/workbench/contrib/chat/common/chatSessionsService.ts Defined internal command interface and added commands to option group interface
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Updated visibility check to include commands when determining if group has items
src/vs/workbench/contrib/chat/browser/chatSessions/searchableOptionPickerActionItem.ts Added ICommandService dependency injection
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionPickerActionItem.ts Implemented command rendering with proper separator and command execution
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionPickerActionItem.ts:118

  • This comment duplicates information from the parent comment (line 105). Since it's directly adjacent to the conditional logic that implements the separation, consider either:
  1. Removing this comment as the logic is self-explanatory with the parent comment, or
  2. Making it more specific: "Separator appears only when there are both items and commands"
					// Use category to create a separator before commands (only if there are options)
					category: addSeparator ? { label: '', order: Number.MAX_SAFE_INTEGER } : undefined,

@DonJayamanne DonJayamanne marked this pull request as ready for review January 23, 2026 00:02
@DonJayamanne DonJayamanne enabled auto-merge (squash) January 23, 2026 00:02
@DonJayamanne DonJayamanne merged commit 49106db into main Jan 23, 2026
26 of 28 checks passed
@DonJayamanne DonJayamanne deleted the don/flat-earthworm branch January 23, 2026 00:03
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 23, 2026
eleanorjboyd pushed a commit to eleanorjboyd/vscode that referenced this pull request Jan 23, 2026
Add comments to chat agent input group options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants