Target picker fixes #289808
Merged
Target picker fixes #289808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshspicer
approved these changes
Jan 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes target picker behavior in the chat interface by ensuring the correct picker is used in welcome view mode, and adjusts menu ordering for better UX.
Changes:
- Modified picker selection logic to use SessionTypePickerActionItem (instead of DelegationSessionPickerActionItem) when in welcome view mode
- Adjusted OpenWorkspacePickerAction menu order from 0.1 to 0.6
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Added logic to detect welcome view mode and select appropriate picker type |
| src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts | Updated menu order for workspace picker to appear after delegation picker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing delegation picker from welcome view