Passing session resource to picker #290079
Merged
+20
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds session resource context to chat session picker action items, allowing commands in option group pickers to receive the current session's URI as their first argument.
Changes:
- Added
sessionResourceparameter toChatSessionPickerActionItemandSearchableOptionPickerActionItemconstructors - Modified command execution to prepend session resource to command arguments when available
- Updated instantiation call in
chatInputPart.tsto pass the session resource
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Passes session resource from view model to picker widgets during instantiation |
| src/vs/workbench/contrib/chat/browser/chatSessions/searchableOptionPickerActionItem.ts | Updates constructor to pass undefined for session resource to parent class |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionPickerActionItem.ts | Adds session resource parameter and logic to prepend it to command arguments |
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionPickerActionItem.ts
Outdated
Show resolved
Hide resolved
roblourens
previously approved these changes
Jan 24, 2026
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
Outdated
Show resolved
Hide resolved
rebornix
previously approved these changes
Jan 24, 2026
dmitrivMS
previously approved these changes
Jan 24, 2026
osortega
force-pushed
the
osortega/toxic-moth
branch
from
9a80d07 to
669c642
Compare
bpasero
approved these changes
Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.