Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Jan 24, 2026

Reverts the revert in #290153. It seems more likely #290159 helps.

Copilot AI review requested due to automatic review settings January 24, 2026 18:41
@bpasero bpasero added this to the January 2026 milestone Jan 24, 2026
@bpasero bpasero self-assigned this Jan 24, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous revert (PR #290153), effectively re-applying changes that prevent Copilot walkthroughs from automatically opening when users have the Agent Sessions Welcome Page configured as their startup editor.

Changes:

  • Adds a check for workbench.startupEditor configuration value before auto-opening walkthroughs on extension installation
  • Prevents walkthrough auto-opening when startupEditor is set to 'agentSessionsWelcomePage'


this.storageService.store(walkthroughMetadataConfigurationKey, JSON.stringify([...this.metadata.entries()]), StorageScope.PROFILE, StorageTarget.USER);

const hadLastFoucs = await this.hostService.hadLastFocus();
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'hadLastFoucs' contains a typo. It should be 'hadLastFocus' (with 'Focus' spelled correctly). This typo appears in both the declaration and usage on line 441.

See below for a potential fix:

		const hadLastFocus = await this.hostService.hadLastFocus();
		const startupEditor = this.configurationService.getValue<string>('workbench.startupEditor');
		if (hadLastFocus && sectionToOpen && this.configurationService.getValue<string>('workbench.welcomePage.walkthroughs.openOnInstall') && startupEditor !== 'agentSessionsWelcomePage') {

Copilot uses AI. Check for mistakes.
@osortega osortega merged commit e585dee into main Jan 24, 2026
27 of 28 checks passed
@osortega osortega deleted the revert-290153-revert-290066-osortega/attractive-stork branch January 24, 2026 21:48
osortega added a commit that referenced this pull request Jan 25, 2026
…-osortega/attractive-stork

Revert "Revert "Do not show copilot walkthrough if agents welcome view is enabled""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants