place system profiles under builtin folder #290359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the file system structure for user data profiles by moving system profiles into a dedicated builtin subfolder, separating them from user-created profiles. This change improves the organization of the profiles directory structure.
Changes:
- Introduces a
SYSTEM_PROFILES_HOMEconstant set to 'builtin' for consistent reference to the system profiles folder - Updates profile storage to use relative paths instead of just basenames, enabling nested folder structures
- Modifies profile creation logic to place system profiles under
builtin/<id>instead of<id> - Implements migration logic to identify and remove system profiles from old locations
- Updates cleanup operations to exclude the
builtinfolder from automatic deletion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/platform/userDataProfile/common/userDataProfile.ts | Adds SYSTEM_PROFILES_HOME constant, implements migration logic to remove old system profiles not under builtin/, updates profile creation to use nested paths for system profiles, excludes builtin folder from cleanup, and adds donotTrigger parameter to suppress events during migration |
| src/vs/platform/userDataProfile/node/userDataProfile.ts | Changes storage format from basename to relative path to support nested folder structures like builtin/<id> |
| } | ||
|
|
||
| private updateProfiles(added: IUserDataProfile[], removed: IUserDataProfile[], updated: IUserDataProfile[]): void { | ||
| private updateProfiles(added: IUserDataProfile[], removed: IUserDataProfile[], updated: IUserDataProfile[], donotTrigger: boolean = false): void { |
There was a problem hiding this comment.
The parameter name 'donotTrigger' does not follow camelCase naming conventions. It should be 'doNotTrigger' with a capital 'N' to be consistent with naming patterns used throughout the VS Code codebase (such as 'doNotSuggest', 'doNotAskAgain', etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.