Skip to content

Enhance light bulb functionality with observable state management and tooltip updates in inline chat editor affordance #290365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrieken merged 1 commit into from
Jan 26, 2026
Merged

Enhance light bulb functionality with observable state management and tooltip updates in inline chat editor affordance #290365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/vs/editor/contrib/codeAction/browser/codeActionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { onUnexpectedError } from '../../../../base/common/errors.js';
import { HierarchicalKind } from '../../../../base/common/hierarchicalKind.js';
import { Lazy } from '../../../../base/common/lazy.js';
import { Disposable, MutableDisposable } from '../../../../base/common/lifecycle.js';
import { derived, IObservable } from '../../../../base/common/observable.js';
import { localize } from '../../../../nls.js';
import { IActionListDelegate } from '../../../../platform/actionWidget/browser/actionList.js';
import { IActionWidgetService } from '../../../../platform/actionWidget/browser/actionWidget.js';
Expand All @@ -38,7 +39,7 @@ import { ApplyCodeActionReason, applyCodeAction } from './codeAction.js';
import { CodeActionKeybindingResolver } from './codeActionKeybindingResolver.js';
import { toMenuItems } from './codeActionMenu.js';
import { CodeActionModel, CodeActionsState } from './codeActionModel.js';
import { LightBulbWidget } from './lightBulbWidget.js';
import { LightBulbInfo, LightBulbWidget } from './lightBulbWidget.js';

interface IActionShowOptions {
readonly includeDisabledActions?: boolean;
Expand Down Expand Up @@ -67,6 +68,14 @@ export class CodeActionController extends Disposable implements IEditorContribut

private _disposed = false;

public readonly lightBulbState: IObservable<LightBulbInfo | undefined> = derived(this, reader => {
const widget = this._lightBulbWidget.rawValue;
if (!widget) {
return undefined;
}
return widget.lightBulbInfo.read(reader);
});
Comment on lines +71 to +77
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The derived observable reads _lightBulbWidget.rawValue, which is a non-observable Lazy value. If the Lazy hasn't been evaluated when this derived observable is first read (e.g., from QuickFixActionViewItem), it will return undefined and won't create a reactive dependency on the widget's lightBulbInfo. Later, even when the Lazy is evaluated and the widget exists, the derived observable won't automatically update because it doesn't observe the Lazy itself. Consider eagerly evaluating the Lazy in the constructor (by accessing .value), or restructure this to ensure the widget exists before the observable is read. The current implementation may work in typical scenarios where code actions are triggered before InlineChatEditorAffordance is shown, but it's not guaranteed to work in all cases.

Copilot uses AI. Check for mistakes.

constructor(
editor: ICodeEditor,
@IMarkerService markerService: IMarkerService,
Expand Down
Loading
Loading