mcp: update apps spec to align with stable spec #290483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align VS Code's MCP Apps implementation with the latest specification from modelcontextprotocol/ext-apps: - Add availableDisplayModes to McpUiAppCapabilities interface (commit 89f58bf) to allow Views to declare supported display modes during initialization. VS Code supports only 'inline' mode currently. - Fix ui/request-display-mode handler to return { mode: 'inline' } per spec requirement, instead of empty response. - Update JSDoc comments to use 'View' terminology consistently instead of 'Guest UI' (following commit 4fc7165). - Verify CSP handling for script-src/style-src with resourceDomains is correct (commit df49e88). Already implemented correctly in chatMcpAppModel._injectPreamble(). Note: styles.css.fonts, ui.domain, and other changes either don't require action or are already implemented. (Commit message generated by Copilot)
benvillalobos
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates VS Code's MCP (Model Context Protocol) Apps implementation to align with the latest specification from the modelcontextprotocol/ext-apps repository. The changes ensure VS Code correctly implements the stable MCP Apps spec for handling Views (formerly "Guest UI") and their display modes.
Changes:
- Update protocol version from "2025-11-21" to "2026-01-26" to reflect the latest spec
- Add
availableDisplayModesfield toMcpUiAppCapabilitiesinterface to allow Views to declare supported display modes - Fix
ui/request-display-modehandler to return{ mode: 'inline' }instead of empty response, per spec requirement - Update JSDoc comments to use "View" terminology consistently with the latest spec
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/mcp/common/modelContextProtocolApps.ts | Updates protocol version constant, adds availableDisplayModes field to app capabilities interface, and updates JSDoc comments to use "View" terminology |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatMcpAppModel.ts | Fixes ui/request-display-mode handler to return proper response with inline mode, and updates JSDoc comment from "Guest UI" to "View" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align VS Code's MCP Apps implementation with the latest specification
from modelcontextprotocol/ext-apps:
Add availableDisplayModes to McpUiAppCapabilities interface
(commit 89f58bf) to allow Views to declare supported display modes
during initialization. VS Code supports only 'inline' mode currently.
Fix ui/request-display-mode handler to return { mode: 'inline' }
per spec requirement, instead of empty response.
Update JSDoc comments to use 'View' terminology consistently
instead of 'Guest UI' (following commit 4fc7165).
Verify CSP handling for script-src/style-src with resourceDomains
is correct (commit df49e88). Already implemented correctly in
chatMcpAppModel._injectPreamble().
Note: styles.css.fonts, ui.domain, and other changes either don't
require action or are already implemented.
(Commit message generated by Copilot)