Fix bad use of ResourcePool - register disposables to wrapper, not pool class #290505
+35
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290328
Problem
The factory methods in
CollapsibleListPoolandTreePoolwere registering disposables (likeResourceLabelsand tree container scopes) to the pool class viathis._register()instead of associating them with the pool item. This meant they would only be disposed when the entire pool was disposed, not when individual items were cleared or released.Solution
This copies the correct strategy used by
CollapsibleChangesSummaryListPool:ICollapsibleListWrapper,ITreePoolWrapper) that implementIDisposableDisposableStorein the factory method to track the item's disposablesdispose()method that cleans up the storeget()to unwrap and return the inner list/tree while properly releasing the wrapper