Skip to content

Conversation

@karthiknadig
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 26, 2026 22:24
@karthiknadig karthiknadig self-assigned this Jan 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a "Skip All" button to the chat question carousel and enhances the visual styling of radio buttons and checkboxes with custom CSS styling.

Changes:

  • Adds a "Skip All" button (when allowSkip is true) that calls the ignore() method to dismiss the carousel without providing answers
  • Implements custom CSS styling for radio buttons and checkboxes including appearance, checked states, focus, and hover effects
  • Restructures the footer layout using a flexbox spacer to separate the Skip All button (left) from navigation buttons (right)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
chatQuestionCarousel.css Adds comprehensive custom styling for radio/checkbox inputs (appearance, checked states, focus/hover effects) and updates footer layout with align-items and spacer classes
chatQuestionCarouselPart.ts Adds Skip All button conditionally based on allowSkip property, creates spacer element for layout, updates disableAllButtons to handle the new button, and adds comment about hiding back button for single questions
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts:108

  • While the ignore() method has existing test coverage, there are no tests verifying that the Skip All button is rendered when allowSkip is true, or that clicking it correctly triggers the ignore() method. Consider adding tests to verify: 1) Skip All button is rendered when allowSkip is true, 2) Skip All button is not rendered when allowSkip is false, and 3) clicking the Skip All button calls ignore() and submits undefined.
		if (this.carousel.allowSkip) {
			this._skipAllButton = this._register(new Button(this._navigationButtons, { ...defaultButtonStyles, secondary: true }));
			this._skipAllButton.label = localize('skipAll', 'Skip All');
			this._skipAllButton.element.classList.add('chat-question-skip-all');
			this._register(this._skipAllButton.onDidClick(() => this.ignore()));
		}

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

@karthiknadig karthiknadig marked this pull request as ready for review January 27, 2026 00:58
@karthiknadig karthiknadig enabled auto-merge (squash) January 27, 2026 00:58
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 27, 2026
@karthiknadig karthiknadig merged commit 30a58d4 into main Jan 27, 2026
22 checks passed
@karthiknadig karthiknadig deleted the widespread-puffin branch January 27, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants