allow prompt for input detection in bg terminals #291325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
requested review from
Tyriar and
Copilot
and removed request for
Copilot
Tyriar
approved these changes
Jan 28, 2026
Comment on lines
809
to
814
| // Wait for the start marker to be created (which creates the outputMonitor) | ||
| await startMarkerPromise; | ||
| if (outputMonitor) { | ||
| await Event.toPromise(outputMonitor.onDidFinishCommand); | ||
| pollingResult = outputMonitor.pollingResult; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #290983
The
outputMonitoris created inside an event handler that fires when the command starts executing. For foreground terminals this worked because the code awaits the full command execution, giving the event time to fire and create the monitor. But for background terminals, the code checkedif (outputMonitor)immediately after callingexecution.start(), before the event had a chance to fire. SooutputMonitorwas always undefined and the input prompting was skipped entirely. The fix addsawait startMarkerPromisebefore checkingoutputMonitor, ensuring the monitor actually exists before we try to use it.