-
Notifications
You must be signed in to change notification settings - Fork 37.8k
Fix inline chat gutter affordance with sticky scroll #291357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…m sticky scroll Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
|
@copilot This is good but actually misses the case when the |
Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
Moved the reveal call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where clicking the inline chat gutter affordance in sticky scroll would show the widget out of frame, as the actual cursor line could be outside the viewport.
Changes:
- Added a call to
revealLineInCenterIfOutsideViewportwithScrollType.Immediatebefore showing the inline chat input widget to ensure the target line is visible when the affordance is triggered from sticky scroll or other contexts where the line may be outside the viewport
When
inlineChat.affordance: gutteris enabled, clicking the affordance displayed in sticky scroll shows the widget out of frame since the actual cursor line may be outside the viewport.Changes:
revealLineInCenterIfOutsideViewportinInlineChatAffordancebefore showing theInlineChatInputWidgetScrollType.Immediateto avoid animation delay before menu appearsshowMenuAtSelection()callsThis follows the existing pattern used in sticky scroll controller, rename widget, and comments controller.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.