fix #291360 #291528
Merged
fix #291360 #291528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies what the “Visible” / “Hidden” filters and visibility grouping mean in the Chat Models management UI by explicitly tying them to the Chat Model Picker.
Changes:
- Reorders the filter menu so capability filters come first.
- Updates visibility filter labels to “Visible/Hidden in Chat Model Picker” for clarity.
- Updates the “Group By” visibility label to include Chat Model Picker context.
Comment on lines
+238
to
+239
| actions.push(this.createVisibleAction(true, localize('filter.visible', "Visible in Chat Model Picker"))); | ||
| actions.push(this.createVisibleAction(false, localize('filter.hidden', "Hidden in Chat Model Picker"))); |
There was a problem hiding this comment.
The new visibility filter labels omit the article “the” (e.g., “Visible in Chat Model Picker”). Elsewhere in this file the UI consistently refers to “the chat model picker” (e.g., tooltips and context menu items like “Hide in the Chat Model Picker”), so these labels should use the same phrasing for consistency and readability.
chrmarti
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #291360