-
Notifications
You must be signed in to change notification settings - Fork 37.8k
Revert "Chat - implement session picker in the chat panel title" #291619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
)" This reverts commit 653daa0.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
@bpaseroMatched files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts the changes from PR #281051, which implemented a session picker feature in the chat panel title that allowed positioning the quick input picker anchored to a specific UI element.
Changes:
- Removes the anchor parameter from
AgentSessionsPickerand updates all instantiation sites - Removes the
anchorproperty from quick input interfaces (IPickOptions,IQuickInput) - Removes anchor-based positioning logic from
quickInputController.ts, including drag-and-drop control disabling - Deletes
src/vs/base/common/layout.tsfile containing 2D layout utilities - Moves layout logic and type definitions back into
src/vs/base/browser/ui/contextview/contextview.ts - Updates
layoutfunction signature to return a number instead of an object with metadata - Removes CSS styles for disabling drag on anchored quick inputs
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewTitleControl.ts | Removes anchor element reference and updates AgentSessionsPicker instantiation |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsPicker.ts | Removes anchor parameter from constructor and picker configuration |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts | Updates AgentSessionsPicker instantiation to remove undefined parameter |
| src/vs/platform/quickinput/common/quickInput.ts | Removes anchor property from IPickOptions and IQuickInput interfaces |
| src/vs/platform/quickinput/browser/quickInputController.ts | Removes anchor positioning logic, restores centered layout, removes drag control disabling |
| src/vs/platform/quickinput/browser/media/quickInput.css | Removes no-drag cursor styles |
| src/vs/base/test/browser/ui/contextview/contextview.test.ts | Updates imports and test assertions for simplified layout function return value |
| src/vs/base/common/layout.ts | Deletes entire file containing 2D layout utilities |
| src/vs/base/browser/ui/menu/menu.ts | Updates import and removes .position access from layout function calls |
| src/vs/base/browser/ui/contextview/contextview.ts | Inlines layout logic, moves type definitions, restores previous implementation |
|
|
||
| if (viewSize <= viewportSize - layoutAfterAnchorBoundary && layoutBeforeAnchorBoundary < viewSize / 2) { | ||
| return layoutAfterAnchorBoundary; // ok case, lay it out after the anchor | ||
| } | ||
|
|
||
|
|
Copilot
AI
Jan 29, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are extra blank lines in the layout function that appear inconsistent with the surrounding code style. Line 129 has an extra blank line before the second if statement, and line 134 has an extra blank line before the final return statement.
| if (viewSize <= viewportSize - layoutAfterAnchorBoundary && layoutBeforeAnchorBoundary < viewSize / 2) { | |
| return layoutAfterAnchorBoundary; // ok case, lay it out after the anchor | |
| } | |
| if (viewSize <= viewportSize - layoutAfterAnchorBoundary && layoutBeforeAnchorBoundary < viewSize / 2) { | |
| return layoutAfterAnchorBoundary; // ok case, lay it out after the anchor | |
| } |
Reverts #281051