chat: add post-approval feedback message #291712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds display of a localized 'Approve tool result?' message when a chat response is waiting for post-approval confirmation on a tool invocation. - Updates ChatResponseModel to detect WaitingForPostApproval state - Displays appropriate confirmation message to user during tool approval - Improves UX by providing clear feedback on what action is needed (Commit message generated by Copilot)
bpasero
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a localized user-facing message to display when a chat response is waiting for post-approval confirmation on a tool invocation. The change improves the UX by providing clear feedback to users about what action is needed.
Changes:
- Adds detection of
WaitingForPostApprovalstate in theChatResponseModelclass - Returns a localized message "Approve tool result?" when in this state
- Follows the same pattern used for
WaitingForConfirmationstate
Comment on lines
+1033
to
+1035
| if (state.type === IChatToolInvocation.StateKind.WaitingForPostApproval) { | ||
| return localize('waitingForPostApproval', "Approve tool result?"); | ||
| } |
There was a problem hiding this comment.
The change adds a localized message for the WaitingForPostApproval state, but there's no test coverage for this new behavior. The existing test in chatModel.test.ts (lines 692-739) only tests the WaitingForConfirmation state. Consider adding a similar test case that verifies isPendingConfirmation.detail returns the correct message when a tool is in WaitingForPostApproval state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds display of a localized 'Approve tool result?' message when a chat
response is waiting for post-approval confirmation on a tool invocation.
(Commit message generated by Copilot)